Implement L_Op for join_dims and split_dims
#1812
Merged
+48
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve type hints for `join_dims` and `split_dims`
jessegrabowski
force-pushed
the
split-join-grad
branch
from
3499a60 to
54c9e69
Compare
ricardoV94
reviewed
Jan 2, 2026
ricardoV94
approved these changes
Jan 2, 2026
jessegrabowski
force-pushed
the
split-join-grad
branch
from
fb4b0b5 to
b79fa63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split from #1806 . Implements gradients for
join_dimsandsplit_dims, now with 100% lessreshapecalls!Also "improves" type hints for
join_dimsandsplit_dims.Related Issue
Checklist
Type of change